Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build,deps,v8: loose ends #26666

Merged
merged 1 commit into from Mar 16, 2019

Conversation

Projects
None yet
7 participants
@refack
Copy link
Member

commented Mar 14, 2019

Some loose ends for #25852

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@refack

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21550/
/CC @nodejs/v8-update @nodejs/build-files if this passes CI I'd like to fast-track this, as it makes #25852 more correct. Please 👍 here if you agree.

@targos

targos approved these changes Mar 14, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

Micro-nit: Commit message first word should be an imperative verb, so maybe tie up loose ends or take care of loose ends or something like that?

@refack refack force-pushed the refack:v8-7.3 branch from f8a4f64 to 63b4747 Mar 14, 2019

Show resolved Hide resolved deps/v8/gypfiles/v8.gyp Outdated
Show resolved Hide resolved deps/v8/gypfiles/v8.gyp Outdated
Show resolved Hide resolved deps/v8/gypfiles/v8.gyp Outdated
@refack
Copy link
Member Author

left a comment

addressed comments

Show resolved Hide resolved deps/v8/gypfiles/v8.gyp Outdated
Show resolved Hide resolved deps/v8/gypfiles/v8.gyp Outdated
Show resolved Hide resolved deps/v8/gypfiles/v8.gyp Outdated
Show resolved Hide resolved deps/v8/gypfiles/v8.gyp Outdated
@ryzokuken
Copy link
Member

left a comment

Thanks! Much needed.

@refack refack removed the fast-track label Mar 15, 2019

build,deps,v8: tie up loose ends
PR-URL: #26666
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>

@refack refack force-pushed the refack:v8-7.3 branch from 437b1ea to 6608cf2 Mar 16, 2019

@refack refack merged commit 6608cf2 into nodejs:master Mar 16, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@refack refack deleted the refack:v8-7.3 branch Mar 16, 2019

@refack refack removed their assignment Mar 16, 2019

Drieger added a commit to Drieger/node that referenced this pull request Mar 22, 2019

build,deps,v8: tie up loose ends
PR-URL: nodejs#26666
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.