Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: elevate v8 namespaces for PropertyAttribute #26681

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
8 participants
@gengjiawen
Copy link
Member

commented Mar 15, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: elevate v8 namespaces for PropertyAttribute
Signed-off-by: gengjiawen <technicalcute@gmail.com>
@targos

targos approved these changes Mar 15, 2019

@BridgeAR

This comment has been minimized.

@ZYSzys

ZYSzys approved these changes Mar 18, 2019

@ZYSzys

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Landed in cf51ee4

@ZYSzys ZYSzys closed this Mar 18, 2019

ZYSzys added a commit that referenced this pull request Mar 18, 2019

src: elevate v8 namespaces for PropertyAttribute
PR-URL: #26681
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

Drieger added a commit to Drieger/node that referenced this pull request Mar 22, 2019

src: elevate v8 namespaces for PropertyAttribute
PR-URL: nodejs#26681
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

src: elevate v8 namespaces for PropertyAttribute
PR-URL: nodejs#26681
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

src: elevate v8 namespaces for PropertyAttribute
PR-URL: nodejs#26681
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

src: elevate v8 namespaces for PropertyAttribute
PR-URL: nodejs#26681
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

targos added a commit that referenced this pull request Mar 27, 2019

src: elevate v8 namespaces for PropertyAttribute
PR-URL: #26681
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

@targos targos referenced this pull request Mar 27, 2019

Merged

v11.13.0 release proposal #26949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.