Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: only open HandleScope when necessary #26734

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@addaleax
Copy link
Member

commented Mar 18, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@danbev

danbev approved these changes Mar 21, 2019

@danbev

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 21, 2019

src: only open HandleScope when necessary
PR-URL: nodejs#26734
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Landed in bca23f2 🎉

@BridgeAR BridgeAR closed this Mar 21, 2019

@joyeecheung joyeecheung referenced this pull request Mar 22, 2019

Closed

CI failures: 20190322 #21

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

src: only open HandleScope when necessary
PR-URL: nodejs#26734
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

src: only open HandleScope when necessary
PR-URL: nodejs#26734
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

src: only open HandleScope when necessary
PR-URL: nodejs#26734
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

targos added a commit that referenced this pull request Mar 27, 2019

src: only open HandleScope when necessary
PR-URL: #26734
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

@targos targos referenced this pull request Mar 27, 2019

Merged

v11.13.0 release proposal #26949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.