Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: optimize test-http2-large-file #26737

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Mar 18, 2019

Optimize test-http2-large-file so it only allocates a single buffer.

I don't expect that this will resolve #22327, but one small change at a time....

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: optimize test-http2-large-file
Optimize test-http2-large-file so it only allocates a single buffer.
@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

Again, I don't expect this to fix the test flakiness, but hey, let's check, and let's at least make sure it doesn't make things obviously worse....

Stress test on master using a Rackspace host: https://ci.nodejs.org/job/node-stress-single-test/2165/nodes=win2008r2-vs2017/

Stress test on this PR using a Rackspace host: https://ci.nodejs.org/job/node-stress-single-test/2166/

(The test failures in #22327 only seem to happen on Rackspace + Win 2008 R2, at least recently.)

@Trott Trott added the http2 label Mar 18, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

Sorry to ping but I was hoping to get a review or two by now? @nodejs/http2 @nodejs/testing

@mcollina
Copy link
Member

left a comment

LGTM

@ZYSzys
ZYSzys approved these changes Mar 19, 2019

@Trott Trott added the author ready label Mar 19, 2019

@edsadr
edsadr approved these changes Mar 20, 2019
Copy link
Member

left a comment

LGTM

@Trott

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2019

Landed in ba1c5ff.

@Trott Trott closed this Mar 20, 2019

Trott added a commit to Trott/io.js that referenced this pull request Mar 20, 2019
test: optimize test-http2-large-file
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: nodejs#26737
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos added a commit to targos/node that referenced this pull request Mar 27, 2019
test: optimize test-http2-large-file
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: nodejs#26737
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos added a commit to targos/node that referenced this pull request Mar 27, 2019
test: optimize test-http2-large-file
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: nodejs#26737
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos added a commit to targos/node that referenced this pull request Mar 27, 2019
test: optimize test-http2-large-file
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: nodejs#26737
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos added a commit that referenced this pull request Mar 27, 2019
test: optimize test-http2-large-file
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: #26737
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
@targos targos referenced this pull request Mar 27, 2019
BethGriggs added a commit that referenced this pull request Apr 17, 2019
test: optimize test-http2-large-file
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: #26737
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
MylesBorins added a commit that referenced this pull request May 16, 2019
test: optimize test-http2-large-file
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: #26737
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.