Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build,meta: quiet/pretty make output by default #26740

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Projects
None yet
5 participants
@refack
Copy link
Member

commented Mar 18, 2019

'cause usually you simply want the job done...
Refs: #26252

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@refack refack added the semver-major label Mar 18, 2019

@refack refack added this to the 12.0.0 milestone Mar 18, 2019

@refack refack self-assigned this Mar 18, 2019

@refack refack requested review from danbev and BridgeAR Mar 18, 2019

@refack

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

/CC @nodejs/build @nodejs/build-files

Semver-Major since downstream embedders (and our CI) depend on make's output.

@refack refack added the meta label Mar 18, 2019

@rvagg

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

previous discussion, you might want to check with people involved in that: #10403

@rvagg

rvagg approved these changes Mar 19, 2019

Copy link
Member

left a comment

fwiw I don't see this as semver-major, I'm not aware of anyone that relies on compiler output in a breaking way. In our CI we could just run make with V=1 everywhere if folks were concerned enough to see the output (I'm not, I like having less output, it makes Jenkins more manageable!).

@refack

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

/PING @trevnorris @bnoordhuis @addaleax @gibfahn

BTW: The pretty format comes from GYP

quiet_cmd_cc = CC($(TOOLSET)) $@
cmd_cc = $(CC.$(TOOLSET)) -o $@ $< $(GYP_CFLAGS) $(DEPFLAGS) $(CFLAGS.$(TOOLSET)) -c
quiet_cmd_cxx = CXX($(TOOLSET)) $@
cmd_cxx = $(CXX.$(TOOLSET)) -o $@ $< $(GYP_CXXFLAGS) $(DEPFLAGS) $(CXXFLAGS.$(TOOLSET)) -c

So that could be easily be manipulated as well.

AS for Jenkins, my dream is nodejs/build#1517

@refack

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

fwiw I don't see this as semver-major, I'm not aware of anyone that relies on compiler output in a breaking way.

We've had complaints before 🤷‍♂️

@danbev

danbev approved these changes Mar 19, 2019

@BridgeAR

This comment has been minimized.

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

build,meta: quiet/pretty make output by default
PR-URL: #26740
Refs: #26252
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.