Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix DTrace GC callbacks DCHECKs and add cleanup #26742

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@joyeecheung
Copy link
Member

commented Mar 18, 2019

Use the variant of GC callbacks that takes data to
avoid running into DCHECKs when multiple Environments try to add
the same callback to the same isolate multiple times.
In addition, remove the callbacks in the Environment cleanup hook.

Fixes: #26736

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: fix DTrace GC callbacks DCHECKs and add cleanup
Use the variant of GC callbacks that takes data to
avoid running into DCHECKs when multiple Environments try to add
the same callback to the same isolate multiple times.
In addition, remove the callbacks in the Environment cleanup hook.

@joyeecheung joyeecheung requested a review from addaleax Mar 18, 2019

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2019

@danbev

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Landed in f47adfb.

@danbev danbev closed this Mar 21, 2019

danbev added a commit that referenced this pull request Mar 21, 2019

src: fix DTrace GC callbacks DCHECKs and add cleanup
Use the variant of GC callbacks that takes data to
avoid running into DCHECKs when multiple Environments try to add
the same callback to the same isolate multiple times.
In addition, remove the callbacks in the Environment cleanup hook.

PR-URL: #26742
Fixes: #26736
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.