Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: remove usage of public require('util') #26747

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@dnlup
Copy link
Contributor

commented Mar 18, 2019

Remove the usage of public require('util'), as described in issue:
#26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
_tls_wrap: remove usage of public require('util')
Remove the usage of public require('util'), as described in issue:
  #26546

@BridgeAR BridgeAR changed the title _tls_wrap: remove usage of public require('util') tls: remove usage of public require('util') Mar 22, 2019

@BridgeAR

This comment has been minimized.

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

Landed in a1330af 🎉

@BridgeAR BridgeAR closed this Mar 24, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 24, 2019

tls: remove usage of public require('util')
Remove the usage of public require('util'), as described in:
nodejs#26546

PR-URL: nodejs#26747
Refs: nodejs#26546
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.