Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert: reduce internal usage `require('util')` #26750

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@toshi1127
Copy link
Contributor

commented Mar 18, 2019

Remove the usage of public require('util'), as described in issue:
#26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]
@ZYSzys

ZYSzys approved these changes Mar 22, 2019

@ZYSzys

This comment has been minimized.

@BridgeAR BridgeAR changed the title assertion_error: reduce internal usage of public require of util assert: reduce internal usage `require('util')` Mar 22, 2019

@ZYSzys

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

@joyeecheung joyeecheung referenced this pull request Mar 22, 2019

Closed

CI failures: 20190322 #21

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

@ZYSzys

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

Landed in b2b8741 🎉

@ZYSzys ZYSzys closed this Mar 24, 2019

ZYSzys added a commit that referenced this pull request Mar 24, 2019

assert: reduce internal usage of public require of util
PR-URL: #26750
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

assert: reduce internal usage of public require of util
PR-URL: nodejs#26750
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

assert: reduce internal usage of public require of util
PR-URL: nodejs#26750
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

assert: reduce internal usage of public require of util
PR-URL: nodejs#26750
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Mar 27, 2019

assert: reduce internal usage of public require of util
PR-URL: #26750
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

@targos targos referenced this pull request Mar 27, 2019

Merged

v11.13.0 release proposal #26949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.