Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: remove util.inherits in tty.js #26797

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@nd-02110114
Copy link
Contributor

commented Mar 20, 2019

This PR is part of issue #26546

Replaced usage of require('util')

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nd-02110114 nd-02110114 force-pushed the nd-02110114:issue26789/lib-tty branch from 1032611 to f773fbb Mar 20, 2019

Show resolved Hide resolved lib/tty.js
Show resolved Hide resolved lib/tty.js
@nd-02110114

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

Thank you for your advice 🙇
I could fix the build error!

@BridgeAR

This comment has been minimized.

@joyeecheung joyeecheung referenced this pull request Mar 22, 2019

Closed

CI failures: 20190322 #21

@ZYSzys

ZYSzys approved these changes Mar 22, 2019

@ZYSzys

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

@ZYSzys ZYSzys added the author ready label Mar 22, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 24, 2019

tty: remove util.inherits usage
PR-URL: nodejs#26797
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

Landed in 55e6c68

@nd-02110114 congratulations on your first commit to Node.js! 🎉 Keep up the good work!

@BridgeAR BridgeAR closed this Mar 24, 2019

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

tty: remove util.inherits usage
PR-URL: nodejs#26797
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

tty: remove util.inherits usage
PR-URL: nodejs#26797
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

tty: remove util.inherits usage
PR-URL: nodejs#26797
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

targos added a commit that referenced this pull request Mar 27, 2019

tty: remove util.inherits usage
PR-URL: #26797
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

@targos targos referenced this pull request Mar 27, 2019

Merged

v11.13.0 release proposal #26949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.