Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace_events: remove usage of require('util') #26822

Closed
wants to merge 1 commit into from

Conversation

@dnlup
Copy link
Contributor

commented Mar 20, 2019

Use require('internal/util/inspect').format instead of
require('util').format.

Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
trace_events: remove usage of require('util')
Use `require('internal/util/inspect').format` instead of 
`require('util').format`.

Refs: #26546
@shisama

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

@ZYSzys
ZYSzys approved these changes Mar 24, 2019
@ZYSzys

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

Landed in a894514 🎉

@ZYSzys ZYSzys closed this Mar 24, 2019

ZYSzys added a commit that referenced this pull request Mar 24, 2019
trace_events: remove usage of require('util')
Use `require('internal/util/inspect').format` instead of
`require('util').format`.

Refs: #26546

PR-URL: #26822
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos added a commit to targos/node that referenced this pull request Mar 27, 2019
trace_events: remove usage of require('util')
Use `require('internal/util/inspect').format` instead of
`require('util').format`.

Refs: nodejs#26546

PR-URL: nodejs#26822
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos added a commit to targos/node that referenced this pull request Mar 27, 2019
trace_events: remove usage of require('util')
Use `require('internal/util/inspect').format` instead of
`require('util').format`.

Refs: nodejs#26546

PR-URL: nodejs#26822
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos added a commit to targos/node that referenced this pull request Mar 27, 2019
trace_events: remove usage of require('util')
Use `require('internal/util/inspect').format` instead of
`require('util').format`.

Refs: nodejs#26546

PR-URL: nodejs#26822
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos added a commit that referenced this pull request Mar 27, 2019
trace_events: remove usage of require('util')
Use `require('internal/util/inspect').format` instead of
`require('util').format`.

Refs: #26546

PR-URL: #26822
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targos targos referenced this pull request Mar 27, 2019
BethGriggs added a commit that referenced this pull request Apr 17, 2019
trace_events: remove usage of require('util')
Use `require('internal/util/inspect').format` instead of
`require('util').format`.

Refs: #26546

PR-URL: #26822
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
MylesBorins added a commit that referenced this pull request May 16, 2019
trace_events: remove usage of require('util')
Use `require('internal/util/inspect').format` instead of
`require('util').format`.

Refs: #26546

PR-URL: #26822
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.