Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
buffer: stricter `from()` input validation #26825
So far we did not throw an error for all types of invalid input.
@cjihrig you opened your PR (#26743) to address the function part first. Please feel free to reopen your PR and I'll either rebase on top of your or just close mine if you would like to pull in my changes.
@ChALkeR you also said that you have a PR almost ready, I am happy to close this one.
@nodejs/tsc is this semver-major because of the function validation (if a function is passed in, it seems like a bug, so I am not sure)? The message part is AFAIK not semver-major.