Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add note about mkdtemp() platform differences #26944

Merged
merged 1 commit into from Mar 30, 2019

Conversation

@cjihrig
Copy link
Contributor

commented Mar 27, 2019

Fixes: #26435

I'm not sure how strongly anyone feels about this, but I could potentially emit a warning if the provided prefix string ends with X.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@lpinca
lpinca approved these changes Mar 27, 2019
@apapirovski
Copy link
Member

left a comment

This seems good but I do wonder whether a warning would be more clear. I imagine most people will find this after trying to debug this issue for a while rather than before.

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

@apapirovski I'll add the warning. I think it will be a source of bugs and frustration if it does happen. Most people would never see the warning anyway.

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

@apapirovski warning added in #26980.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

Copy link

commented Mar 30, 2019

doc: add note about mkdtemp() platform differences
PR-URL: #26944
Fixes: #26435
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

@cjihrig cjihrig force-pushed the cjihrig:docs branch from 72ffa5b to dd9cad9 Mar 30, 2019

@cjihrig cjihrig merged commit dd9cad9 into nodejs:master Mar 30, 2019

0 of 2 checks passed

Travis CI - Branch Build Errored
Details
Travis CI - Pull Request Build Errored
Details

@cjihrig cjihrig deleted the cjihrig:docs branch Mar 30, 2019

BethGriggs added a commit that referenced this pull request Apr 5, 2019
doc: add note about mkdtemp() platform differences
PR-URL: #26944
Fixes: #26435
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
BethGriggs added a commit that referenced this pull request Apr 8, 2019
doc: add note about mkdtemp() platform differences
PR-URL: #26944
Fixes: #26435
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs referenced this pull request Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.