Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various change for src #26959

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
8 participants
@gengjiawen
Copy link
Contributor

gengjiawen commented Mar 28, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Show resolved Hide resolved src/inspector_socket.cc Outdated

@gengjiawen gengjiawen force-pushed the gengjiawen:src_misc_19_03_28 branch from 9730426 to 961ed67 Apr 2, 2019

@gengjiawen gengjiawen force-pushed the gengjiawen:src_misc_19_03_28 branch from 961ed67 to 4458671 Apr 2, 2019

@BridgeAR BridgeAR requested review from eugeneo and refack Apr 3, 2019

@gengjiawen

This comment has been minimized.

Copy link
Contributor Author

gengjiawen commented Apr 5, 2019

@danbev Can you import this pr, thanks.

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Apr 5, 2019

@gengjiawen I'd like to give @eugeneo a chance to approve this as there was a change requested. Once that is done I'd be happy to merge this.

@refack

refack approved these changes Apr 5, 2019

@gengjiawen

This comment has been minimized.

Copy link
Contributor Author

gengjiawen commented Apr 9, 2019

ping @eugeneo

The relevant changes have been reverted

@nodejs-github-bot

This comment has been minimized.

@gengjiawen

This comment has been minimized.

Copy link
Contributor Author

gengjiawen commented Apr 13, 2019

@danbev @refack Can we land this ?

BridgeAR added a commit to BridgeAR/node that referenced this pull request Apr 16, 2019

src: remove unimplemented method in TracingAgent
PR-URL: nodejs#26959
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

BridgeAR added a commit to BridgeAR/node that referenced this pull request Apr 16, 2019

src: remove redundant call in node_options-inl.h
PR-URL: nodejs#26959
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Apr 16, 2019

Landed in 7347123 and 1e7823d 🎉

@BridgeAR BridgeAR closed this Apr 16, 2019

@gengjiawen gengjiawen deleted the gengjiawen:src_misc_19_03_28 branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.