Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: list when promiseResolve hook was added to async_hooks #26978

Closed
wants to merge 1 commit into from

Conversation

@watson
Copy link
Member

commented Mar 29, 2019

Refs: #15296

Checklist
@nodejs-github-bot

This comment has been minimized.

Copy link

commented Mar 29, 2019

@watson Sadly, an error occurred when I tried to trigger a build. :(

@Qard
Qard approved these changes Mar 29, 2019
@BridgeAR

This comment has been minimized.

@watson

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

The Travis test took too long to run and was killed. Is there a way I can restart it?

@watson watson self-assigned this Apr 1, 2019

@watson

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2019

Landed in fcdee74

@watson watson closed this Apr 1, 2019

@watson watson deleted the watson:ah branch Apr 1, 2019

watson added a commit that referenced this pull request Apr 1, 2019
doc: list when promiseResolve hook was added to async_hooks
PR-URL: #26978
Refs: #15296
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 5, 2019
doc: list when promiseResolve hook was added to async_hooks
PR-URL: #26978
Refs: #15296
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 9, 2019
doc: list when promiseResolve hook was added to async_hooks
PR-URL: #26978
Refs: #15296
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs added a commit that referenced this pull request Apr 9, 2019
doc: list when promiseResolve hook was added to async_hooks
PR-URL: #26978
Refs: #15296
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs referenced this pull request Apr 9, 2019
BethGriggs added a commit that referenced this pull request Apr 10, 2019
doc: list when promiseResolve hook was added to async_hooks
PR-URL: #26978
Refs: #15296
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.