Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child_process: doc deprecate ChildProcess._channel #26982

Merged
merged 1 commit into from Mar 31, 2019

Conversation

Projects
None yet
6 participants
@cjihrig
Copy link
Contributor

commented Mar 29, 2019

This was eligible to begin deprecation in Node 8.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Copy link

commented Mar 29, 2019

@cjihrig Sadly, an error occurred when I tried to trigger a build. :(

Show resolved Hide resolved doc/api/deprecations.md Outdated

@cjihrig cjihrig force-pushed the cjihrig:depr branch from 9f210a6 to 8d4e903 Mar 30, 2019

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

Copy link

commented Mar 31, 2019

child_process: doc deprecate ChildProcess._channel
This was eligible to begin deprecation in Node 8.

PR-URL: #26982
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:depr branch from 8d4e903 to 9b70a5c Mar 31, 2019

@cjihrig cjihrig merged commit 9b70a5c into nodejs:master Mar 31, 2019

@cjihrig cjihrig deleted the cjihrig:depr branch Mar 31, 2019

BethGriggs added a commit that referenced this pull request Apr 5, 2019

child_process: doc deprecate ChildProcess._channel
This was eligible to begin deprecation in Node 8.

PR-URL: #26982
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

BethGriggs added a commit that referenced this pull request Apr 9, 2019

child_process: doc deprecate ChildProcess._channel
This was eligible to begin deprecation in Node 8.

PR-URL: #26982
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>

BethGriggs added a commit that referenced this pull request Apr 9, 2019

child_process: doc deprecate ChildProcess._channel
This was eligible to begin deprecation in Node 8.

PR-URL: #26982
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>

@BethGriggs BethGriggs referenced this pull request Apr 9, 2019

Merged

v11.14.0 proposal #27163

richardlau added a commit to richardlau/node-1 that referenced this pull request Apr 9, 2019

@richardlau richardlau referenced this pull request Apr 9, 2019

Merged

doc: assign missed deprecation code #27164

3 of 3 tasks complete

richardlau added a commit to richardlau/node-1 that referenced this pull request Apr 10, 2019

doc: assign missed deprecation code
Refs: nodejs#26982

PR-URL: nodejs#27164
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

BethGriggs added a commit that referenced this pull request Apr 10, 2019

doc: assign missed deprecation code
Refs: #26982

PR-URL: #27164
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

BethGriggs added a commit that referenced this pull request Apr 10, 2019

doc: assign missed deprecation code
Refs: #26982

PR-URL: #27164
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

BethGriggs added a commit that referenced this pull request Apr 10, 2019

2019-04-10, Version 11.14.0 (Current)
Notable changes:

- child_process: doc deprecate ChildProcess.\_channel (cjihrig)
  [#26982](#26982)
- deps: update nghttp2 to 1.37.0 (gengjiawen)
  [#26990](#26990)
- dns:
  - make dns.promises enumerable (cjihrig)
    [#26592](#26592)
  - remove dns.promises experimental warning (cjihrig)
    [#26592](#26592)
- stream: make Symbol.asyncIterator support stable (Matteo Collina)
  [#26989](#26989)
- worker: use copy of process.env (Anna Henningsen)
  [#26544](#26544)

PR-URL: #27163

BethGriggs added a commit that referenced this pull request Apr 11, 2019

2019-04-11, Version 11.14.0 (Current)
Notable changes:

- child_process: doc deprecate ChildProcess.\_channel (cjihrig)
  [#26982](#26982)
- deps: update nghttp2 to 1.37.0 (gengjiawen)
  [#26990](#26990)
- dns:
  - make dns.promises enumerable (cjihrig)
    [#26592](#26592)
  - remove dns.promises experimental warning (cjihrig)
    [#26592](#26592)
- fs: remove experimental warning for fs.promises (Anna Henningsen)
  [#26581] (#26581)
- stream: make Symbol.asyncIterator support stable (Matteo Collina)
  [#26989](#26989)
- worker: use copy of process.env (Anna Henningsen)
  [#26544](#26544)

PR-URL: #27163

BethGriggs added a commit that referenced this pull request Apr 11, 2019

2019-04-11, Version 11.14.0 (Current)
Notable changes:

- child_process: doc deprecate ChildProcess.\_channel (cjihrig)
  [#26982](#26982)
- deps: update nghttp2 to 1.37.0 (gengjiawen)
  [#26990](#26990)
- dns:
  - make dns.promises enumerable (cjihrig)
    [#26592](#26592)
  - remove dns.promises experimental warning (cjihrig)
    [#26592](#26592)
- fs: remove experimental warning for fs.promises (Anna Henningsen)
  [#26581] (#26581)
- stream: make Symbol.asyncIterator support stable (Matteo Collina)
  [#26989](#26989)
- worker: use copy of process.env (Anna Henningsen)
  [#26544](#26544)

PR-URL: #27163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.