Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish test coverage for lib/internal/dns/utils.js #27006

Closed
wants to merge 2 commits into from

Conversation

@Trott
Copy link
Member

commented Mar 30, 2019

Add coverage to achieve 100% code coverage in tests for lib/internal/dns/utils.js.

First commit:

dns: refactor lib/internal/dns/utils.js

* alphabetize contenst of `resolverKeys` array
* less line-wrapping for increased code clarity

Second commit:

test: add IPv6 brackets but no port to test-dns

Add a test case to test-dns to check that supply an IPv6 host with
brackets but no explicit port to `dns.setServers()` yields expected
results. This is the final bit of test coverage missing for
lib/internal/dns/utils.js.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Trott added 2 commits Mar 30, 2019
dns: refactor lib/internal/dns/utils.js
* alphabetize contenst of `resolverKeys` array
* less line-wrapping for increased code clarity
test: add IPv6 brackets but no port to test-dns
Add a test case to test-dns to check that supply an IPv6 host with
brackets but no explicit port to `dns.setServers()` yields expected
results. This is the final bit of test coverage missing for
lib/internal/dns/utils.js.
@nodejs-github-bot

This comment has been minimized.

@Trott Trott changed the title Ref dns utils finish test coverage for lib/internal/dns/utils.js Mar 30, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2019

Landed in c6faf5b...8afab1a

@Trott Trott closed this Apr 1, 2019

Trott added a commit to Trott/io.js that referenced this pull request Apr 1, 2019
dns: refactor lib/internal/dns/utils.js
* alphabetize contenst of `resolverKeys` array
* less line-wrapping for increased code clarity

PR-URL: nodejs#27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Apr 1, 2019
test: add IPv6 brackets but no port to test-dns
Add a test case to test-dns to check that supply an IPv6 host with
brackets but no explicit port to `dns.setServers()` yields expected
results. This is the final bit of test coverage missing for
lib/internal/dns/utils.js.

PR-URL: nodejs#27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 5, 2019
dns: refactor lib/internal/dns/utils.js
* alphabetize contenst of `resolverKeys` array
* less line-wrapping for increased code clarity

PR-URL: #27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 5, 2019
test: add IPv6 brackets but no port to test-dns
Add a test case to test-dns to check that supply an IPv6 host with
brackets but no explicit port to `dns.setServers()` yields expected
results. This is the final bit of test coverage missing for
lib/internal/dns/utils.js.

PR-URL: #27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 9, 2019
dns: refactor lib/internal/dns/utils.js
* alphabetize contenst of `resolverKeys` array
* less line-wrapping for increased code clarity

PR-URL: #27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs added a commit that referenced this pull request Apr 9, 2019
test: add IPv6 brackets but no port to test-dns
Add a test case to test-dns to check that supply an IPv6 host with
brackets but no explicit port to `dns.setServers()` yields expected
results. This is the final bit of test coverage missing for
lib/internal/dns/utils.js.

PR-URL: #27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs added a commit that referenced this pull request Apr 9, 2019
dns: refactor lib/internal/dns/utils.js
* alphabetize contenst of `resolverKeys` array
* less line-wrapping for increased code clarity

PR-URL: #27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs added a commit that referenced this pull request Apr 9, 2019
test: add IPv6 brackets but no port to test-dns
Add a test case to test-dns to check that supply an IPv6 host with
brackets but no explicit port to `dns.setServers()` yields expected
results. This is the final bit of test coverage missing for
lib/internal/dns/utils.js.

PR-URL: #27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs referenced this pull request Apr 9, 2019
BethGriggs added a commit that referenced this pull request Apr 10, 2019
dns: refactor lib/internal/dns/utils.js
* alphabetize contenst of `resolverKeys` array
* less line-wrapping for increased code clarity

PR-URL: #27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs added a commit that referenced this pull request Apr 10, 2019
test: add IPv6 brackets but no port to test-dns
Add a test case to test-dns to check that supply an IPv6 host with
brackets but no explicit port to `dns.setServers()` yields expected
results. This is the final bit of test coverage missing for
lib/internal/dns/utils.js.

PR-URL: #27006
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.