Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve the doc of the 'information' event #27009

Closed
wants to merge 1 commit into from

Conversation

@lpinca
Copy link
Member

commented Mar 30, 2019

  • Add missing argument
  • Reword a sentence
  • Rename the res argument to info in the example to avoid confusion

Fixes: #26905

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc: improve the doc of the 'information' event
- Add missing argument
- Reword a sentence
- Rename the `res` argument to `info` in the example to avoid confusion

Fixes: #26905

@lpinca lpinca force-pushed the lpinca:gh-26905 branch from 862a0a4 to bd17e0d Mar 30, 2019

@BridgeAR

This comment has been minimized.

@danbev
danbev approved these changes Apr 2, 2019
@danbev

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Landed in 0a5a762.

@danbev danbev closed this Apr 2, 2019

danbev added a commit that referenced this pull request Apr 2, 2019
doc: improve the doc of the 'information' event
- Add missing argument
- Reword a sentence
- Rename the `res` argument to `info` in the example to avoid confusion

PR-URL: #27009
Fixes: #26905
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

@lpinca lpinca deleted the lpinca:gh-26905 branch Apr 2, 2019

BethGriggs added a commit that referenced this pull request Apr 5, 2019
doc: improve the doc of the 'information' event
- Add missing argument
- Reword a sentence
- Rename the `res` argument to `info` in the example to avoid confusion

PR-URL: #27009
Fixes: #26905
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 9, 2019
doc: improve the doc of the 'information' event
- Add missing argument
- Reword a sentence
- Rename the `res` argument to `info` in the example to avoid confusion

PR-URL: #27009
Fixes: #26905
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs added a commit that referenced this pull request Apr 9, 2019
doc: improve the doc of the 'information' event
- Add missing argument
- Reword a sentence
- Rename the `res` argument to `info` in the example to avoid confusion

PR-URL: #27009
Fixes: #26905
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs referenced this pull request Apr 9, 2019
BethGriggs added a commit that referenced this pull request Apr 10, 2019
doc: improve the doc of the 'information' event
- Add missing argument
- Reword a sentence
- Rename the `res` argument to `info` in the example to avoid confusion

PR-URL: #27009
Fixes: #26905
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.