Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build,win: silence MSVC warning C4129 for V8 #27017

Merged
merged 1 commit into from Mar 31, 2019

Conversation

Projects
None yet
5 participants
@refack
Copy link
Member

commented Mar 30, 2019

Currently we get 13,799 of those per build

/CC @nodejs/build-files @nodejs/v8-update

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@refack refack self-assigned this Mar 30, 2019

@refack refack added the fast-track label Mar 30, 2019

@refack

This comment has been minimized.

Copy link
Member Author

commented Mar 30, 2019

Windows-CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/26038 ✔️

If this passes, please 👍 for fast tracking since this kinda makes the console output usable again.

build,win: silence MSVC warning C4129 for V8
Currently we get 13,799 of those per build

PR-URL: #27017
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@refack refack force-pushed the refack:silence-msvc-C4129-for-V8 branch from cae7a72 to d379e45 Mar 31, 2019

@refack refack merged commit d379e45 into nodejs:master Mar 31, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@refack refack deleted the refack:silence-msvc-C4129-for-V8 branch Mar 31, 2019

@refack refack referenced this pull request Mar 31, 2019

Closed

Windows build failure #102

BethGriggs added a commit that referenced this pull request Apr 5, 2019

build,win: silence MSVC warning C4129 for V8
Currently we get 13,799 of those per build

PR-URL: #27017
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BethGriggs added a commit that referenced this pull request Apr 9, 2019

build,win: silence MSVC warning C4129 for V8
Currently we get 13,799 of those per build

PR-URL: #27017
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>

BethGriggs added a commit that referenced this pull request Apr 9, 2019

build,win: silence MSVC warning C4129 for V8
Currently we get 13,799 of those per build

PR-URL: #27017
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>

@BethGriggs BethGriggs referenced this pull request Apr 9, 2019

Merged

v11.14.0 proposal #27163

@refack refack removed their assignment Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.