Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: force using primordials for JSON, Math and Reflect #27027

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
10 participants
@targos
Copy link
Member

commented Mar 31, 2019

Use the "no-restricted-globals" ESLint rule to lint for it.

lib: force using primordials for JSON, Math and Reflect
Use the "no-restricted-globals" ESLint rule to lint for it.
@joyeecheung

This comment has been minimized.

Copy link
Member

commented Mar 31, 2019

I don’t think we have to make this semver-major? Monkey patching JS builtins is not something we provide any stability guarantees for?

@nodejs-github-bot

This comment has been minimized.

@targos targos removed the semver-major label Mar 31, 2019

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Should we also do safemap and safeset?

@targos

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2019

@MylesBorins
Maybe in another PR?

@lpinca

lpinca approved these changes Apr 1, 2019

@nodejs-github-bot

This comment has been minimized.

@ZYSzys

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

Landed in 0817840 🎉

@ZYSzys ZYSzys closed this Apr 3, 2019

ZYSzys added a commit that referenced this pull request Apr 3, 2019

lib: force using primordials for JSON, Math and Reflect
Use the "no-restricted-globals" ESLint rule to lint for it.

PR-URL: #27027
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@targos targos deleted the targos:primordial-ns branch Apr 3, 2019

BethGriggs added a commit that referenced this pull request Apr 4, 2019

lib: force using primordials for JSON, Math and Reflect
Use the "no-restricted-globals" ESLint rule to lint for it.

PR-URL: #27027
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

dsanders11 added a commit to dsanders11/node that referenced this pull request Jun 22, 2019

lib: force using primordials for JSON, Math and Reflect
Use the "no-restricted-globals" ESLint rule to lint for it.

PR-URL: nodejs/node#27027
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MarshallOfSound added a commit to electron/node that referenced this pull request Jun 26, 2019

lib: force using primordials for JSON, Math and Reflect
Use the "no-restricted-globals" ESLint rule to lint for it.

PR-URL: nodejs/node#27027
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.