Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child_process: harden fork arguments validation #27039

Closed
wants to merge 1 commit into from
Closed
child_process: harden fork arguments validation
1 successful check

Travis CI - Pull Request

Success

ran Apr 2, 2019 in 24 minutes

b77a6b2 by @ZYSzys

Build Passed

The build passed, just like the previous build.

Details

This is a pull request build.

It is running a build against the merge commit, after merging #27039 child_process: harden fork arguments validation.
Any changes that have been made to the master branch before the build ran are also included.

Jobs and Stages

This build has five jobs, running in two sequential stages.

Stage 1: Lint and compile

This stage passed.

Job Node.js State
15636.1 First commit message adheres to guidelines at https://goo.gl/p2fr5Q node passed
15636.2 Linter node passed
15636.3 Compile V8 passed
15636.4 Compile Node.js passed

Stage 2: Tests

This stage passed.

Job State
15636.5 Test Suite passed

Build Configuration

Build Option Setting
Language Ruby
Operating System Linux (Xenial)
Build Configuration
{
  "os": "linux",
  "dist": "xenial",
  "jobs": {
    "include": [
      {
        "if": "type = pull_request",
        "name": "First commit message adheres to guidelines at <a href=\"https://goo.gl/p2fr5Q\">https://goo.gl/p2fr5Q</a>",
        "stage": "Lint and Compile",
        "script": [
          "if [ \"${TRAVIS_PULL_REQUEST}\" != \"false\" ]; then bash -x tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST}; fi"
        ],
        "node_js": "node",
        "language": "node_js"
      },
      {
        "name": "Linter",
        "script": [
          "NODE=$(which node) make lint-ci"
        ],
        "install": [
          "make lint-py-build || true"
        ],
        "node_js": "node",
        "language": "node_js"
      },
      {
        "name": "Compile V8",
        "cache": "ccache",
        "addons": {
          "apt": {
            "sources": [
              "ubuntu-toolchain-r-test"
            ],
            "packages": [
              "g++-6"
            ]
          }
        },
        "script": [
          "CC='ccache gcc-6' CXX='ccache g++-6' make -j2 -C out V=1 v8"
        ],
        "install": [
          "CC='ccache gcc-6' CXX='ccache g++-6' ./configure"
        ],
        "language": "cpp"
      },
      {
        "name": "Compile Node.js",
        "cache": "ccache",
        "addons": {
          "apt": {
            "sources": [
              "ubuntu-toolchain-r-test"
            ],
            "packages": [
              "g++-6"
            ]
          }
        },
        "script": [
          "CC='ccache gcc-6' CXX='ccache g++-6' make -j2 V=1"
        ],
        "install": [
          "CC='ccache gcc-6' CXX='ccache g++-6' ./configure"
        ],
        "language": "cpp"
      },
      {
        "name": "Test Suite",
        "cache": "ccache",
        "stage": "Tests",
        "addons": {
          "apt": {
            "sources": [
              "ubuntu-toolchain-r-test"
            ],
            "packages": [
              "g++-6"
            ]
          }
        },
        "script": [
          "JOBS=2 FLAKY_TESTS=skip make -s -j1 V= test-ci | grep -F -e \"---\" -e \"...\" -v"
        ],
        "install": [
          "export CC='ccache gcc-6' CXX='ccache g++-6' JOBS=2",
          "./configure",
          "make -j2 > /dev/null",
          "make -j1 build-addons build-js-native-api-tests build-node-api-tests > /dev/null"
        ],
        "language": "cpp"
      }
    ]
  },
  "group": "stable",
  ".result": "configured",
  "language": "ruby"
}
You can’t perform that action at this time.