Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert: fix rejects stack trace and operator #27047

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
5 participants
@BridgeAR
Copy link
Member

commented Apr 2, 2019

This makes sure the stack trace is not removed due to a wrong stack
start function being used. It also fixes the wrong operator caused
by the same reason. This only applies in case an validation object
was used to validate the rejection passed to assert.reject() as
first argument.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
assert: fix rejects stack trace and operator
This makes sure the stack trace is not removed due to a wrong stack
start function being used. It also fixes the wrong operator caused
by the same reason. This only applies in case an validation object
was used to validate the rejection passed to `assert.reject()` as
first argument.
@nodejs-github-bot

This comment has been minimized.

@BridgeAR

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

@BridgeAR BridgeAR requested a review from targos Apr 3, 2019

@BridgeAR

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

@nodejs/util @nodejs/assert PTAL. This could use some reviews.

@nodejs-github-bot

This comment has been minimized.

@BridgeAR BridgeAR requested a review from Trott Apr 5, 2019

@Trott

Trott approved these changes Apr 6, 2019

@nodejs-github-bot

This comment has been minimized.

@jasnell

jasnell approved these changes Apr 6, 2019

@nodejs-github-bot

This comment has been minimized.

Show resolved Hide resolved test/parallel/test-assert-async.js Outdated
Show resolved Hide resolved test/parallel/test-assert-async.js
@nodejs-github-bot

This comment has been minimized.

BridgeAR added a commit that referenced this pull request Apr 7, 2019

assert: fix rejects stack trace and operator
This makes sure the stack trace is not removed due to a wrong stack
start function being used. It also fixes the wrong operator caused
by the same reason. This only applies in case an validation object
was used to validate the rejection passed to `assert.reject()` as
first argument.

PR-URL: #27047
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member Author

commented Apr 7, 2019

Landed in 75463a9 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.