Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test vm.runInNewContext() filename option #27056

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
8 participants
@bnoordhuis
Copy link
Member

commented Apr 2, 2019

The 'filename as a string' case was already being tested. This commit
also exercises the 'filename as an option' case.

test: test vm.runInNewContext() filename option
The 'filename as a string' case was already being tested. This commit
also exercises the 'filename as an option' case.
@nodejs-github-bot

This comment has been minimized.

@lpinca

lpinca approved these changes Apr 2, 2019

@cjihrig

cjihrig approved these changes Apr 2, 2019

@nodejs-github-bot

This comment has been minimized.

@devsnek

devsnek approved these changes Apr 3, 2019

@bnoordhuis

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

New CI, the last one ran into infrastructure problems: https://ci.nodejs.org/job/node-test-pull-request/22168/

@nodejs-github-bot

This comment has been minimized.

@bnoordhuis

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

The failure is #26910.

@nodejs-github-bot

This comment has been minimized.

@danbev

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

Landed in f13733d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.