Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't use lint-ci on Travis #27062

Merged
merged 1 commit into from Apr 5, 2019

Conversation

Projects
None yet
5 participants
@richardlau
Copy link
Member

commented Apr 2, 2019

The lint-ci Makefile target differs from lint in that it writes to
a tap file and not stdout and also stops execution when an error is
found (e.g. if JavaScript linting fails the C++ and docs linting are
not run).

The switch to lint-ci was to enable Python linting. Revert to lint
and add the lint-py target.

Example Travis run where lint is used (note that C++ and docs linting occur after the JavaScript linter fails):
https://travis-ci.com/nodejs/node/jobs/189665652

Example Travis run where lint-ci is used (note that C++ and docs linting are not attempted after JavaScript linter fails and the actual linter failure is not visible):
https://travis-ci.com/nodejs/node/jobs/189720838

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@richardlau richardlau requested a review from refack Apr 2, 2019

@richardlau

This comment has been minimized.

Copy link
Member Author

commented Apr 2, 2019

If it was just the case of the linter failure not being visible we could echo the tap file in the after_failure Travis phase. I think it's more helpful though if all of the linters are run so you get all the failures in one go.

@refack

refack approved these changes Apr 2, 2019

build: don't use lint-ci on Travis
The `lint-ci` Makefile target differs from `lint` in that it writes to
a tap file and not stdout and also stops execution when an error is
found (e.g. if JavaScript linting fails the C++ and docs linting are
not run).

The switch to `lint-ci` was to enable Python linting. Revert to `lint`
and add the `lint-py` target.

PR-URL: #27062
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@richardlau richardlau force-pushed the richardlau:travislint branch from 5ead90b to af03de4 Apr 5, 2019

@richardlau

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

Landed in af03de4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.