Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: patch V8 to 7.4.288.18 #27066

Merged
merged 2 commits into from Apr 5, 2019

Conversation

Projects
None yet
4 participants
@targos
Copy link
Member

commented Apr 3, 2019

Refs: v8/v8@7.4.288.13...7.4.288.17

@nodejs/v8-update

@nodejs-github-bot

This comment has been minimized.

@targos

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

@nodejs-github-bot

This comment has been minimized.

@cjihrig

cjihrig approved these changes Apr 3, 2019

@nodejs-github-bot

This comment has been minimized.

@targos targos changed the title deps: patch V8 to 7.4.288.17 deps: patch V8 to 7.4.288.18 Apr 5, 2019

@targos

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

Updated to 7.4.288.18. I need at least one more approval.

@targos

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@refack

refack approved these changes Apr 5, 2019

Copy link
Member

left a comment

RSLGTM

targos added some commits Apr 3, 2019

deps: patch V8 to 7.4.288.17
Refs: v8/v8@7.4.288.13...7.4.288.17

PR-URL: #27066
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
deps: patch V8 to 7.4.288.18
Refs: v8/v8@7.4.288.17...7.4.288.18

PR-URL: #27066
Refs: v8/v8@7.4.288.13...7.4.288.17
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@refack refack force-pushed the targos:v8-patch branch from a68ef97 to 135b79a Apr 5, 2019

@refack

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

Landed in c86883c...135b79a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.