Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in CLI docs, --entry-type error message #27067

Closed
wants to merge 1 commit into from

Conversation

@GeoffreyBooth
Copy link
Contributor

commented Apr 3, 2019

Fix some minor typos in docs and an error message.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@targos

targos approved these changes Apr 3, 2019

@ZYSzys

ZYSzys approved these changes Apr 3, 2019

@nodejs-github-bot

This comment has been minimized.

@devsnek

devsnek approved these changes Apr 3, 2019

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@cjihrig

cjihrig approved these changes Apr 3, 2019

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

Landed in 5e98f87
Thank you!

vsemozhetbyt added a commit that referenced this pull request Apr 3, 2019

esm: fix typos
PR-URL: #27067
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@GeoffreyBooth GeoffreyBooth deleted the GeoffreyBooth:fix-typos branch Apr 3, 2019

BethGriggs added a commit that referenced this pull request Apr 4, 2019

esm: fix typos
PR-URL: #27067
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.