Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise Collaborator description in GOVERNANCE.md #27071

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Apr 3, 2019

  • Active voice
  • Remove Node.js Foundation mention. It may be appropriate to add
    something back in when the new foundation is bootstrapped. We
    don't control membership criteria, so best to link to something else
    when it becomes available rather than make guarantees in this doc.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc: revise Collaborator description in GOVERNANCE.md
* Active voice
* Remove Node.js Foundation mention. It may be appropriate to add
  something back in when the new foundation is bootstrapped. We
  don't control membership criteria, so best to link to something else
  when it becomes available rather than make guarantees in this doc.
@nodejs-github-bot

This comment has been minimized.

@Trott Trott added the author ready label Apr 3, 2019

@lpinca
lpinca approved these changes Apr 3, 2019
@ZYSzys
ZYSzys approved these changes Apr 4, 2019
@jasnell
jasnell approved these changes Apr 4, 2019
@hiroppy
hiroppy approved these changes Apr 4, 2019
@mhdawson
Copy link
Member

left a comment

LGTM

@Trott

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

Landed in 181052d

@Trott Trott closed this Apr 5, 2019

Trott added a commit to Trott/io.js that referenced this pull request Apr 5, 2019
doc: revise Collaborator description in GOVERNANCE.md
* Active voice
* Remove Node.js Foundation mention. It may be appropriate to add
  something back in when the new foundation is bootstrapped. We
  don't control membership criteria, so best to link to something else
  when it becomes available rather than make guarantees in this doc.

PR-URL: nodejs#27071
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.