Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: fix custom inspection with extra properties #27074

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@BridgeAR
Copy link
Member

commented Apr 3, 2019

This broke due to a recent change that prevents exposing inspect
internals. It now relies on the public API instead and should be a
bit more "robust" due to that (it's still bad but I see no good alternative :D).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
buffer: fix custom inspection with extra properties
This broke due to a recent change that prevents exposing inspect
internals. It now relies on the public API instead and should be a
bit more robust due to that.
@nodejs-github-bot

This comment has been minimized.

@BridgeAR BridgeAR requested a review from targos Apr 3, 2019

@targos

targos approved these changes Apr 3, 2019

@nodejs-github-bot

This comment has been minimized.

@BridgeAR

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

@BridgeAR

This comment has been minimized.

Copy link
Member Author

commented Apr 7, 2019

This could use another review :)

Show resolved Hide resolved lib/buffer.js
@ZYSzys

ZYSzys approved these changes Apr 8, 2019

danbev added a commit to danbev/node that referenced this pull request Apr 8, 2019

buffer: fix custom inspection with extra properties
This broke due to a recent change that prevents exposing inspect
internals. It now relies on the public API instead and should be a
bit more robust due to that.

PR-URL: nodejs#27074
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@danbev

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

Landed in d834275.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.