Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix section sorting, add link reference #27075

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@vsemozhetbyt
Copy link
Contributor

commented Apr 3, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

After #27037, system errors section is unified with other class sections, so it should be placed between Class: SyntaxError and Class: TypeError sections.

Also, a missing bottom reference is added with the new URL.

@nodejs-github-bot

This comment has been minimized.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@lpinca

lpinca approved these changes Apr 3, 2019

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

Landed in 10eaf6a
Thank you for the reviews.

vsemozhetbyt added a commit that referenced this pull request Apr 3, 2019

doc: fix section sorting, add link reference
PR-URL: #27075
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-errors-nits branch Apr 3, 2019

BethGriggs added a commit that referenced this pull request Apr 4, 2019

doc: fix section sorting, add link reference
PR-URL: #27075
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.