Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: print a better message for unexpected use of globals #27083

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
7 participants
@targos
Copy link
Member

commented Apr 4, 2019

The error looks like this now:

  23:11  error  Unexpected use of 'Reflect'. Use `const { Reflect } = primordials;` instead of the global  no-restricted-globals
@nodejs-github-bot

This comment has been minimized.

@targos targos referenced this pull request Apr 4, 2019

Closed

lib: make FreeList faster #27021

3 of 3 tasks complete
@ZYSzys

ZYSzys approved these changes Apr 4, 2019

@lpinca

lpinca approved these changes Apr 4, 2019

@cjihrig

cjihrig approved these changes Apr 4, 2019

@targos

This comment has been minimized.

Copy link
Member Author

commented Apr 6, 2019

Landed in dd89a11

@targos targos closed this Apr 6, 2019

@targos targos deleted the targos:primordials-message branch Apr 6, 2019

targos added a commit that referenced this pull request Apr 6, 2019

tools: print a better message for unexpected use of globals
PR-URL: #27083
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.