Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: simplify missing passphrase detection #27089

Conversation

Projects
None yet
6 participants
@tniessen
Copy link
Member

tniessen commented Apr 4, 2019

This commit removes the PasswordCallbackInfo class introduced in #25208 and uses existing OpenSSL error handling APIs to detect missing passphrases instead. This should not cause any observable differences for users, but slightly simplifies and shortens our code.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Show resolved Hide resolved src/node_crypto.cc Outdated
@sam-github
Copy link
Member

sam-github left a comment

Code looks good. Its completely backwards compatible? No test changes needed at all? If so, its nice to delete code!

@danbev

danbev approved these changes Apr 5, 2019

@nodejs-github-bot

This comment has been minimized.

Show resolved Hide resolved src/node_crypto.cc Outdated
@nodejs-github-bot

This comment has been minimized.

@tniessen

This comment has been minimized.

Copy link
Member Author

tniessen commented Apr 6, 2019

Its completely backwards compatible? No test changes needed at all? If so, its nice to delete code!

As far as I know, there should be no difference whatsoever.

@jasnell

jasnell approved these changes Apr 6, 2019

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Apr 8, 2019

Landed in fadcb2d.

@danbev danbev closed this Apr 8, 2019

danbev added a commit that referenced this pull request Apr 8, 2019

crypto: simplify missing passphrase detection
PR-URL: #27089
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.