Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: use SealHandleScope for inspector tasks #27116

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@addaleax
Copy link
Member

commented Apr 6, 2019

This addresses a TODO comment that can be resolved,
now that we have V8 7.4.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: use SealHandleScope for inspector tasks
This addresses a TODO comment that can be resolved,
now that we have V8 7.4.
@nodejs-github-bot

This comment has been minimized.

@jasnell

jasnell approved these changes Apr 8, 2019

Copy link
Member

left a comment

LGTM.

Side note: it would be useful to document somewhere when it is appropriate to use each of these.

@addaleax addaleax referenced this pull request Apr 8, 2019

Draft

WIP V8 API usage in Node.js #26929

0 of 4 tasks complete
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@danbev

danbev approved these changes Apr 10, 2019

@danbev

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Landed in c1e03ed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.