Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: remove dead code #27125

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
9 participants
@marcosc90
Copy link
Contributor

marcosc90 commented Apr 7, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Removed unreachable code. In line 511, state.ended is set to true. So process.nextTick(emitReadable_, stream); can't be reached.

stream: remove dead code
Remove unreachable code. `state.ended` is always set to true
in this part of the code. The `else` clause can't be executed.

@addaleax addaleax requested a review from mcollina Apr 7, 2019

@mcollina
Copy link
Member

mcollina left a comment

LGTM with green CITGM

@ZYSzys

ZYSzys approved these changes Apr 8, 2019

@nodejs-github-bot

This comment has been minimized.

@cjihrig

cjihrig approved these changes Apr 8, 2019

@ZYSzys ZYSzys added the author ready label Apr 8, 2019

@jasnell

jasnell approved these changes Apr 8, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Apr 10, 2019

stream: remove dead code
Remove unreachable code. `state.ended` is always set to true
in this part of the code. The `else` clause can't be executed.

PR-URL: nodejs#27125
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Apr 10, 2019

Landed in 1a67c99 🎉

@BridgeAR BridgeAR closed this Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.