Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: tidy up additional libraries on Windows #27138

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
5 participants
@richardlau
Copy link
Member

commented Apr 8, 2019

The report functionality that depended on Dbghelp.lib and Psapi.lib
are actually in src/debug_utils.cc and are not dependent on the
report functionality being enabled.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@richardlau

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2019

@nodejs-github-bot

This comment has been minimized.

Copy link

commented Apr 8, 2019

@refack

refack approved these changes Apr 8, 2019

@cjihrig

cjihrig approved these changes Apr 8, 2019

build: tidy up additional libraries on Windows
The report functionality that depended on `Dbghelp.lib` and `Psapi.lib`
are actually in `src/debug_utils.cc` and are not dependent on the
report functionality being enabled.

PR-URL: #27138
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@richardlau richardlau force-pushed the richardlau:winlibs branch from 30e016f to 72f4a83 Apr 11, 2019

@richardlau

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

Landed in 72f4a83.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.