Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unnecessary function call #27143

Closed

Conversation

Projects
None yet
4 participants
@tniessen
Copy link
Member

tniessen commented Apr 9, 2019

Personally, I prefer a single call to .release() over .get() followed by .release() without using the return value since the former is closer to "move semantics". As always, feel free to disagree :-)

Refs: #27092

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Apr 9, 2019

This does not have the same behaviour in the return false; case, though … Is this still correct, i.e. do we have a memory leak right now?

@tniessen

This comment has been minimized.

Copy link
Member Author

tniessen commented Apr 9, 2019

I assumed OpenSSL took ownership either way, but I checked and you are right, it doesn't, so this won't work.

@tniessen tniessen closed this Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.