Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: enforce the use of Object from primordials #27146

Closed
wants to merge 1 commit into from

Conversation

@targos
Copy link
Member

commented Apr 9, 2019

No description provided.

@nodejs-github-bot

This comment has been minimized.

@cjihrig

cjihrig approved these changes Apr 9, 2019

Copy link
Contributor

left a comment

LGTM if the CI passes.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@joyeecheung joyeecheung referenced this pull request Apr 10, 2019

Closed

lib: create primordials in every context #27171

2 of 2 tasks complete
@danbev

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Landed in 908292c.

@trptcolin

This comment has been minimized.

Copy link

commented May 18, 2019

I just wanted to say thank you for this fix! 🙇 ❤️ Much appreciated.

Bumped up against this issue on an older node version due to a userspace monkey-patch (of Object.defineProperty in an ES5 shim from one of our dependencies, and I'm glad to see someone's already done the hard work of solving the underlying issue. Thanks!

@targos targos deleted the targos:primordial-object branch May 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.