Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
build,win: put all compilation artifacts into `out` #27149
Solves (almost completely) the unnecessary distribution of build artifacts all over the repo.
Also has some small tweaks.
what's left to solve is the locations of the
referenced this pull request
Apr 9, 2019
I've just spent a long time trying to work out why changes I made weren't being reflected when I run
node.vcxproj -> out\Release\\node.exe You do not have sufficient privilege to perform this operation. C:\work\node\github\nodejs>
Unfortunately I didn't immediately spot this and ended up running the old
Does this work on later versions of Windows without Administrator privileges? (I can't check on Windows 10 until Monday at the earliest).
Thanks for the report.
Did vcbuild.bat exit at that point?
It was an issue that was addressed by MS for Windows 10 (at least, maybe even for Windows 8.1).
On CI we do run under an admin account by in an non privileged session, so that's half way to a proper testing env (we do not CI test with Windows 7, but we do with Server2008R2 which is the equivalent Server release).
Originally I fixed that, but choose to revert because of CI legacy issues...
P.S. posted a notice at https://github.com/orgs/nodejs/teams/collaborators/discussions/72
No it continues, which is why I missed it the first few times and only really spotted it when I cut down my