Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: remove trace frame #27159

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
9 participants
@BridgeAR
Copy link
Member

commented Apr 9, 2019

The own function's frame was removed originally. This restors that
behavior.

Fixes: #27134

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
console: remove trace frame
The own function's frame was removed originally. This restors that
behavior.

Fixes: #27134
@nodejs-github-bot

This comment has been minimized.

@eugeneo

eugeneo approved these changes Apr 9, 2019

@richardlau
Copy link
Member

left a comment

Commit message has a typo (restors).

@targos

targos approved these changes Apr 9, 2019

@@ -330,13 +330,13 @@ const consoleMethods = {
trace(kTraceInstant, kTraceConsoleCategory, `time::${label}`, 0);
},

trace(...args) {
trace: function trace(...args) {

This comment has been minimized.

Copy link
@targos

targos Apr 9, 2019

Member

Is this strictly needed? I thought the shorthand notation had the same behavior.

This comment has been minimized.

Copy link
@BridgeAR

BridgeAR Apr 10, 2019

Author Member

With the shorthand notation, the function would be called as obj.property. It is not possible to access the function itself by only using the property name. That is only possible inside the old function foo type.

It would also be possible if this would not be a property but a variable.

@BridgeAR BridgeAR closed this Apr 10, 2019

@BridgeAR BridgeAR reopened this Apr 10, 2019

@nodejs-github-bot

This comment has been minimized.

@ZYSzys

ZYSzys approved these changes Apr 10, 2019

@lpinca

lpinca approved these changes Apr 10, 2019

@nodejs-github-bot

This comment has been minimized.

@ZYSzys

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Landed in 091902a 🎉

@ZYSzys ZYSzys closed this Apr 12, 2019

targos pushed a commit to targos/node that referenced this pull request Apr 12, 2019

console: remove trace frame
The own function's frame was removed originally. This restors that
behavior.

Fixes: nodejs#27134

PR-URL: nodejs#27159
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.