Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build,tools: use mkcodecache to add code cache to the binaries #27161

Merged
merged 3 commits into from Apr 16, 2019

Conversation

Projects
None yet
4 participants
@refack
Copy link
Member

commented Apr 9, 2019

Based on #27135
and #27108

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment was marked as outdated.

@refack refack referenced this pull request Apr 9, 2019

Closed

tools: implement mkcodecache as an executable #27135

2 of 2 tasks complete

@refack refack requested a review from joyeecheung Apr 9, 2019

@nodejs-github-bot

This comment was marked as outdated.

@refack refack force-pushed the refack:new-mkcodecache branch from 9a599ef to 62e7eb9 Apr 9, 2019

@nodejs nodejs deleted a comment from nodejs-github-bot Apr 9, 2019

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@refack refack force-pushed the refack:new-mkcodecache branch from 8bb0a95 to 71601c8 Apr 10, 2019

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@refack refack force-pushed the refack:new-mkcodecache branch from 53760a3 to 195b71b Apr 10, 2019

@nodejs-github-bot

This comment was marked as outdated.

@refack refack force-pushed the refack:new-mkcodecache branch from 195b71b to 096b602 Apr 10, 2019

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@refack

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2019

Current change-set works on all platforms (except the RPIs), test failures are most probably flakes.

Reviews are welcome.

@nodejs-github-bot

This comment was marked as outdated.

@joyeecheung
Copy link
Member

left a comment

Thanks for working on this!

Show resolved Hide resolved Makefile
Show resolved Hide resolved configure.py

@refack refack force-pushed the refack:new-mkcodecache branch 2 times, most recently from 501a151 to 1d2feb7 Apr 13, 2019

@nodejs-github-bot

This comment was marked as outdated.

@refack refack force-pushed the refack:new-mkcodecache branch 2 times, most recently from 85dca38 to 1328195 Apr 16, 2019

@nodejs-github-bot

This comment has been minimized.

@refack refack force-pushed the refack:new-mkcodecache branch from 1328195 to f413019 Apr 16, 2019

@nodejs-github-bot

This comment has been minimized.

@refack refack changed the title build,tools: mkcodecache (alt version) build,tools: use mkcodecache to add code cache to the binaries Apr 16, 2019

joyeecheung and others added some commits Apr 3, 2019

tools: implement mkcodecache as an executable
This patch implement a mkcodecache executable on top of the
`NativeModuleLoader` singleton.
This makes it possible to build a Node.js binary with embedded
code cache without building itself using the code cache stub -
the cache is now initialized by `NativeModuleEnv` instead which
can be refactored out of the mkcodecache dependencies.

PR-URL: #27161
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
tools: refactor mkcodecache
PR-URL: #27161
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
build: run `mkcodecache` as an action
* fix test-code-cache (for the common cases)
* deprecate `configure --code-cache-path`

PR-URL: #27161
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@refack refack force-pushed the refack:new-mkcodecache branch from f413019 to 14df42f Apr 16, 2019

@refack

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

Landed in 1c26169...14df42f

@refack refack removed the author ready label Apr 16, 2019

@refack refack removed their assignment Apr 16, 2019

@refack refack merged commit 14df42f into nodejs:master Apr 16, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@refack refack added this to the 12.0.0 milestone Apr 16, 2019

@refack refack deleted the refack:new-mkcodecache branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.