Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools,doc: fix 404 broken links in docs #27168

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
7 participants
@07Gond
Copy link
Contributor

commented Apr 10, 2019

Change the linkManPages function to catch the uname and curl correct websites on the docs page.

Fixes: #26074

image

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
tools,doc: fix 404 broken links in docs
Change the linkManPages function to catch the uname and curl
correct websites on the docs page.

Fixes: #26074
Show resolved Hide resolved tools/doc/html.js Outdated
Show resolved Hide resolved tools/doc/html.js Outdated
Show resolved Hide resolved tools/doc/html.js Outdated
@gengjiawen

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

In the long run we should add tools to prevent this ?
I wonder can https://github.com/JustinBeckwith/linkinator integrate to travis-ci ? (Suggested by @bnb )
cc @richardlau @Trott

@richardlau richardlau referenced this pull request Apr 16, 2019

Open

build: add Travis job to check for dead URL links #27267

0 of 4 tasks complete
@richardlau

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

In the long run we should add tools to prevent this ?
I wonder can https://github.com/JustinBeckwith/linkinator integrate to travis-ci ? (Suggested by @bnb )

It's technically possible but would need work: #27267

@vsemozhetbyt

This comment has been minimized.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2019

Landed in 964174e.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.