Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark some known flakes #27193

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
4 participants
@refack
Copy link
Member

commented Apr 11, 2019

Refs: #20750
Refs: #26610

@nodejs/testing PTAL

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@refack

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

I move this should be fast tracked, please 👍 here if you concur.

@nodejs-github-bot

This comment has been minimized.

@Trott

Trott approved these changes Apr 11, 2019

test: mark some known flakes
PR-URL: #27193
Refs: #20750
Refs: #26610
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

@refack refack force-pushed the refack:mark-some-flakes branch from 4808bf1 to abe4183 Apr 11, 2019

@refack

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

Fast tracking with 2 up-votes
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.