Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update js-yaml to 3.13.1 for lint-md.js #27195

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@Trott
Copy link
Member

commented Apr 11, 2019

Update js-yaml from 3.13.0 to 3.13.1 in the lint-md.js tool. Version
3.13.0 is the subject of a security problem. It is almost certainly not
anything that is reasonable exploitable in our code base (as it's
internal tooling) but good to update anyway just in case...

Refs: https://app.snyk.io/vuln/SNYK-JS-JSYAML-174129

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
tools: update js-yaml to 3.13.1 for lint-md.js
Update js-yaml from 3.13.0 to 3.13.1 in the lint-md.js tool. Version
3.13.0 is the subject of a security problem. It is almost certainly not
anything that is reasonable exploitable in our code base (as it's
internal tooling) but good to update anyway just in case...

Refs: https://app.snyk.io/vuln/SNYK-JS-JSYAML-174129
@nodejs-github-bot

This comment has been minimized.

@richardlau
Copy link
Member

left a comment

RSLGTM

@Trott Trott added the author ready label Apr 11, 2019

@ZYSzys

ZYSzys approved these changes Apr 12, 2019

Copy link
Member

left a comment

RSLGTM

@Trott

This comment has been minimized.

Copy link
Member Author

commented Apr 14, 2019

Landed in d4e7431

@Trott Trott closed this Apr 14, 2019

Trott added a commit to Trott/io.js that referenced this pull request Apr 14, 2019

tools: update js-yaml to 3.13.1 for lint-md.js
Update js-yaml from 3.13.0 to 3.13.1 in the lint-md.js tool. Version
3.13.0 is the subject of a security problem. It is almost certainly not
anything that is reasonable exploitable in our code base (as it's
internal tooling) but good to update anyway just in case...

Refs: https://app.snyk.io/vuln/SNYK-JS-JSYAML-174129

PR-URL: nodejs#27195
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.