Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: add benchmark for dns.promises.lookup() #27249

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@Trott
Copy link
Member

commented Apr 16, 2019

Adding this benchmark will let us check the performance implications of
#27081.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@richardlau richardlau added the promises label Apr 16, 2019

@Trott Trott referenced this pull request Apr 16, 2019

Closed

dns: refactor internal/dns/promises.js #27081

2 of 2 tasks complete

@Trott Trott added the author ready label Apr 16, 2019

return;
}
await lookup(name, opts);
cb();

This comment has been minimized.

Copy link
@addaleax

addaleax Apr 16, 2019

Member

If we’re using async/await anyway, would using a loop instead of recursive function calls make sense?

This comment has been minimized.

Copy link
@Trott

Trott Apr 18, 2019

Author Member

Done. PTAL

@Trott Trott force-pushed the Trott:add-dns-lookup-promises-benchmark branch from 82af24d to 449eee0 Apr 18, 2019

benchmark: add benchmark for dns.promises.lookup()
Adding this benchmark will let us check the performance implications of
#27081.

@Trott Trott force-pushed the Trott:add-dns-lookup-promises-benchmark branch from 449eee0 to 57a9ad9 Apr 18, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

@ZYSzys

ZYSzys approved these changes Apr 18, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

Landed in f98679f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.