Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: try to stabilize test-child-process-fork-exec-path.js #27277

Closed

Conversation

Projects
None yet
6 participants
@refack
Copy link
Member

commented Apr 17, 2019

An attempt to de-flake test/parallel/test-child-process-fork-exec-path.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@refack refack force-pushed the refack:stablize-test-child-process-fork-exec-path branch from 3dda26d to 5ec9d3f Apr 17, 2019

@refack

This comment has been minimized.

@refack

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

Still no boeno

c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:27
      throw e;
      ^

Error: ENOTEMPTY: directory not empty, rmdir 'c:\workspace\node-test-binary-windows-2\test\.tmp.3'
    at Object.rmdirSync (fs.js:706:3)
    at rmdirSync (c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:48:10)
    at rimrafSync (c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:18:7)
    at Object.refresh (c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:66:3)
    at process.<anonymous> (c:\workspace\node-test-binary-windows-2\test\parallel\test-child-process-fork-exec-path.js:66:12)

@refack refack force-pushed the refack:stablize-test-child-process-fork-exec-path branch from 5ec9d3f to 31bc7d0 Apr 17, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Is there a good reason we're using tmpdir at all? Why not just use the node executable where it is and don't move/copy/remove anything at all? EDIT: I guess to make sure it's not ignoring the execPath property? I should look more closely at things before writing comments. :-D

@refack

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

I guess to make sure it's not ignoring the execPath property?

70ad9bb

Worth documenting though

@refack refack force-pushed the refack:stablize-test-child-process-fork-exec-path branch from 9a01a9a to 6bdc8d7 Apr 17, 2019

@refack refack force-pushed the refack:stablize-test-child-process-fork-exec-path branch from 6bdc8d7 to 907567e Apr 17, 2019

@nodejs-github-bot

This comment has been minimized.

@refack

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

@nodejs/testing This flake has been failing fairly often in the last few days.
Please 👍 if you approve of fast tracking this.

@refack refack added the fast-track label Apr 17, 2019

@danbev

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Landed in 4f8b497.

@danbev danbev closed this Apr 18, 2019

danbev added a commit that referenced this pull request Apr 18, 2019

test: try to stabalize test-child-process-fork-exec-path.js
PR-URL: #27277
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@refack refack deleted the refack:stablize-test-child-process-fork-exec-path branch Apr 18, 2019

@refack refack added the landed label Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.