Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update nghttp2 to 1.38.0 #27295

Closed
wants to merge 1 commit into from

Conversation

@gengjiawen
Copy link
Member

commented Apr 18, 2019

Release: https://github.com/nghttp2/nghttp2/releases/tag/v1.38.0
Mainly Fix nghttp2/nghttp2#1331.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@gengjiawen

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2019

Need to add semver-minor label.

@ZYSzys
ZYSzys approved these changes Apr 21, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@ZYSzys

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

Landed in 2161690 🎉

@ZYSzys ZYSzys closed this Apr 22, 2019

ZYSzys added a commit that referenced this pull request Apr 22, 2019
deps: update nghttp2 to 1.38.0
PR-URL: #27295
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>

@addaleax addaleax removed the semver-minor label Apr 23, 2019

@addaleax

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

@gengjiawen This doesn’t appear to be a semver-minor change – our cherry-pick only contains a semver-patch part.

@gengjiawen gengjiawen deleted the gengjiawen:nghttp1.38 branch Apr 23, 2019

BethGriggs added a commit that referenced this pull request Aug 15, 2019
deps: update nghttp2 to 1.38.0
Backport-PR-URL: #29123
PR-URL: #27295
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@BethGriggs BethGriggs referenced this pull request Aug 15, 2019
BethGriggs added a commit that referenced this pull request Aug 15, 2019
deps: update nghttp2 to 1.38.0
PR-URL: #27295
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
This was referenced Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.