Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: move OnMessage to node_errors.cc #27304

Closed
wants to merge 1 commit into from

Conversation

@joyeecheung
Copy link
Member

commented Apr 19, 2019

Rename the per-isolate message listener to PerIsolateMessageListener
and move it to node_errors.cc since it's part of the error
handling process. It also creates an external reference so it needs
to be exposed in node_errors.h for a snapshot builder to know.

Refs: #17058 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: move OnMessage to node_errors.cc
Rename the per-isolate message listener to `PerIsolateMessageListener`
and move it to `node_errors.cc` since it's part of the error
handling process. It also creates an external reference so it needs
to be exposed in `node_errors.h` for a snapshot builder to know.
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

Landed in 744cdec

joyeecheung added a commit that referenced this pull request Apr 26, 2019
src: move OnMessage to node_errors.cc
Rename the per-isolate message listener to `PerIsolateMessageListener`
and move it to `node_errors.cc` since it's part of the error
handling process. It also creates an external reference so it needs
to be exposed in `node_errors.h` for a snapshot builder to know.

PR-URL: #27304
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit that referenced this pull request Apr 27, 2019
src: move OnMessage to node_errors.cc
Rename the per-isolate message listener to `PerIsolateMessageListener`
and move it to `node_errors.cc` since it's part of the error
handling process. It also creates an external reference so it needs
to be exposed in `node_errors.h` for a snapshot builder to know.

PR-URL: #27304
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos referenced this pull request Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.