Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip test-cpu-prof in debug builds with code cache #27308

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
6 participants
@joyeecheung
Copy link
Member

commented Apr 19, 2019

The CPU profiler crashes in debug builds when code cache is
enabled. Skip the test temporarily until it's fixed.

Refs: #27307

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: skip test-cpu-prof in debug builds with code cache
The CPU profiler crashes in debug builds when code cache is
enabled. Skip the test temporarily until it's fixed.
@nodejs-github-bot

This comment has been minimized.

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2019

@nodejs-github-bot

This comment has been minimized.

@addaleax
Copy link
Member

left a comment

I’m 👍 to fast-tracking if you want

joyeecheung added some commits Apr 19, 2019

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2019

Fixed the linter and the skip message.

@addaleax Let's see if this is green in CI first..(it passes for me locally, previously it always crashed)

@nodejs-github-bot

This comment has been minimized.

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2019

CI is green. Please thumb this up if you are +1 to fast tracking (this unbreaks debug builds on master)

@nodejs/testing

@ZYSzys

ZYSzys approved these changes Apr 19, 2019

@devsnek devsnek added the fast-track label Apr 19, 2019

@joyeecheung

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2019

Landed in b66f01d

joyeecheung added a commit that referenced this pull request Apr 19, 2019

test: skip test-cpu-prof in debug builds with code cache
The CPU profiler crashes in debug builds when code cache is
enabled. Skip the test temporarily until it's fixed.

PR-URL: #27308
Refs: #27307
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@@ -3,6 +3,13 @@
// This tests that --cpu-prof and --cpu-prof-path works.

const common = require('../common');
if (process.features.debug &&
process.config.variables.node_code_cache_path === 'yes') {

This comment has been minimized.

Copy link
@refack

refack Apr 19, 2019

Member

ATM this is not the best predicate for embedded code-cache...
I've submitted #27311 to fix the value, and this predicate (it could be any non '' value if combined with the previous manual embedding technique)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.