Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: improve embedded code-cache detection #27311

Merged
merged 1 commit into from Apr 22, 2019

Conversation

Projects
None yet
6 participants
@refack
Copy link
Member

commented Apr 19, 2019

Follow up to #27308

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment was marked as outdated.

@refack refack requested a review from joyeecheung Apr 19, 2019

@refack refack referenced this pull request Apr 19, 2019

Closed

test: skip test-cpu-prof in debug builds with code cache #27308

2 of 2 tasks complete

@refack refack force-pushed the refack:fix-config-code-cache-bug branch from 0606363 to 98deba3 Apr 19, 2019

@nodejs-github-bot

This comment has been minimized.

@refack

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2019

Added process.features.code_cache field based on compile time constant, and not build configuration.

@refack refack added the process label Apr 19, 2019

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@refack refack self-assigned this Apr 20, 2019

@refack

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2019

@refack refack force-pushed the refack:fix-config-code-cache-bug branch from f0b5677 to cbf534c Apr 21, 2019

refack added a commit to refack/node that referenced this pull request Apr 21, 2019

build: improve embedded code-cache detection
PR-URL: nodejs#27311
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@nodejs-github-bot

This comment was marked as outdated.

Show resolved Hide resolved configure.py Outdated
Show resolved Hide resolved lib/internal/bootstrap/node.js

@BridgeAR BridgeAR removed the author ready label Apr 21, 2019

@refack refack force-pushed the refack:fix-config-code-cache-bug branch from cbf534c to 4d81c09 Apr 21, 2019

refack added a commit to refack/node that referenced this pull request Apr 21, 2019

build: improve embedded code-cache detection
PR-URL: nodejs#27311
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

@nodejs nodejs deleted a comment from nodejs-github-bot Apr 21, 2019

@nodejs-github-bot

This comment has been minimized.

build: improve embedded code-cache detection
PR-URL: #27311
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

@refack refack force-pushed the refack:fix-config-code-cache-bug branch from 4d81c09 to 5aaf666 Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.