Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update ICU to 64.2 #27361

Closed
wants to merge 2 commits into from

Conversation

@ryzokuken
Copy link
Member

commented Apr 23, 2019

Release Date: April 17th

Fixes: #26388

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

/cc @srl295 @refack @targos 馃帀

NOTE: This is required to make V8's canary work with Node.js again.

@ryzokuken ryzokuken requested review from refack and srl295 Apr 23, 2019

@ryzokuken ryzokuken self-assigned this Apr 23, 2019

@nodejs-github-bot

This comment has been minimized.

@richardlau
Copy link
Member

left a comment

Unrelated license changes, please investigate.

deps: update ICU to 64.2
Update the version of the bundled ICU (deps/icu-small) to ICU version
64.2 (Unicode 12, CLDR 35)

Fixes: #26388

@ryzokuken ryzokuken force-pushed the ryzokuken:icu-64.2 branch from 937dea1 to e8977f5 Apr 23, 2019

@ryzokuken

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

@richardlau @targos PTAL now.

@richardlau
Copy link
Member

left a comment

Second commit LGTM.

RSLGTM for the first commit.

LICENSE Outdated
@@ -114,12 +114,12 @@ The externally maintained libraries used by Node.js are:
IN THE SOFTWARE.
"""

- ICU, located at deps/icu-small, is licensed as follows:
- ICU, located at deps/icu, is licensed as follows:

This comment has been minimized.

Copy link
@targos

targos Apr 23, 2019

Member
Suggested change
- ICU, located at deps/icu, is licensed as follows:
- ICU, located at deps/icu-small, is licensed as follows:
deps: update LICENSE and tools/icu/current_ver.dep
Update the LICENSE file and tools/icu/current_ver.dep file in order to
finalize the upgrade to ICU 64.2

@ryzokuken ryzokuken force-pushed the ryzokuken:icu-64.2 branch from e8977f5 to e5bd726 Apr 23, 2019

@srl295

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

@ryzokuken

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

@srl295 fixed it already! Thanks.

@srl295

srl295 approved these changes Apr 23, 2019

Copy link
Member

left a comment

馃帀 Looks Great To Me!

@srl295 srl295 added the intl label Apr 23, 2019

@srl295

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

filed #27369 (comment) to support sha512 in the current_ver.dep

@srl295 srl295 referenced this pull request Apr 23, 2019

Closed

build: allow icu download to use sha512 over md5 #27370

2 of 2 tasks complete
@mhdawson
Copy link
Member

left a comment

Rubber stamp LGTM

@targos targos referenced this pull request Apr 23, 2019

Open

deps: update V8 to 7.5 #27375

@srl295

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Oh also, this is needed for Japanese Era (Reiwa) support

$ ./node -p "new Date('5/1/2019').toLocaleString('ja-u-ca-japanese', {era: 'long'})"
浠ゅ拰鍏冨勾5鏈1鏃 0:00:00
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@targos

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

Landed in 6bbb9eb...c80c414

@targos targos closed this Apr 25, 2019

targos added a commit that referenced this pull request Apr 25, 2019

deps: update ICU to 64.2
Update the version of the bundled ICU (deps/icu-small) to ICU version
64.2 (Unicode 12, CLDR 35)

Fixes: #26388

PR-URL: #27361
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

targos added a commit that referenced this pull request Apr 25, 2019

tools: update LICENSE and tools/icu/current_ver.dep
Update the LICENSE file and tools/icu/current_ver.dep file in order to
finalize the upgrade to ICU 64.2

PR-URL: #27361
Fixes: #26388
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@refack refack referenced this pull request Apr 25, 2019

Closed

deps: backport ICU-20558 to fix Intl crasher #27415

2 of 2 tasks complete

targos added a commit that referenced this pull request Apr 27, 2019

deps: update ICU to 64.2
Update the version of the bundled ICU (deps/icu-small) to ICU version
64.2 (Unicode 12, CLDR 35)

Fixes: #26388

PR-URL: #27361
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

targos added a commit that referenced this pull request Apr 27, 2019

tools: update LICENSE and tools/icu/current_ver.dep
Update the LICENSE file and tools/icu/current_ver.dep file in order to
finalize the upgrade to ICU 64.2

PR-URL: #27361
Fixes: #26388
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

targos added a commit that referenced this pull request Apr 27, 2019

2019-04-29, Version 12.1.0 (Current)
Notable changes:

* intl:
  * Update ICU to 64.2. This adds support for Japanese Era (Reiwa).
    #27361
  * Fixes a bug in ICU that affected Node.js 12.0.0 in the case where
    `new Date().toLocaleString()` was called with a non-default locale.
    #27415
* C++ API:
  * Added an `Environment` overload of `EmitAsyncDestroy`.
    #27255

PR-URL: TODO

@targos targos referenced this pull request Apr 27, 2019

Merged

v12.1.0 proposal #27440

targos added a commit that referenced this pull request Apr 29, 2019

2019-04-29, Version 12.1.0 (Current)
Notable changes:

* intl:
  * Update ICU to 64.2. This adds support for Japanese Era (Reiwa).
    #27361
  * Fixes a bug in ICU that affected Node.js 12.0.0 in the case where
    `new Date().toLocaleString()` was called with a non-default locale.
    #27415
* C++ API:
  * Added an overload of `EmitAsyncDestroy` that can be used during
    garbage collection.
    #27255

PR-URL: #27440

targos added a commit that referenced this pull request Apr 29, 2019

2019-04-29, Version 12.1.0 (Current)
Notable changes:

* intl:
  * Update ICU to 64.2. This adds support for Japanese Era (Reiwa).
    #27361
  * Fixes a bug in ICU that affected Node.js 12.0.0 in the case where
    `new Date().toLocaleString()` was called with a non-default locale.
    #27415
* C++ API:
  * Added an overload of `EmitAsyncDestroy` that can be used during
    garbage collection.
    #27255

PR-URL: #27440
@shinnn

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Yes, great work @ryzokuken and reviewers! Happy to see this landed before Reiwa starts.

@targos targos referenced this pull request May 1, 2019

Open

v10.16.0 proposal #27514

BethGriggs added a commit that referenced this pull request May 10, 2019

deps: update ICU to 64.2
Update the version of the bundled ICU (deps/icu-small) to ICU version
64.2 (Unicode 12, CLDR 35)

Fixes: #26388

PR-URL: #27361
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

BethGriggs added a commit that referenced this pull request May 10, 2019

tools: update LICENSE and tools/icu/current_ver.dep
Update the LICENSE file and tools/icu/current_ver.dep file in order to
finalize the upgrade to ICU 64.2

PR-URL: #27361
Fixes: #26388
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

BethGriggs added a commit that referenced this pull request May 10, 2019

deps: update ICU to 64.2
Update the version of the bundled ICU (deps/icu-small) to ICU version
64.2 (Unicode 12, CLDR 35)

Fixes: #26388

PR-URL: #27361
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

BethGriggs added a commit that referenced this pull request May 10, 2019

tools: update LICENSE and tools/icu/current_ver.dep
Update the LICENSE file and tools/icu/current_ver.dep file in order to
finalize the upgrade to ICU 64.2

PR-URL: #27361
Fixes: #26388
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request May 16, 2019

deps: update ICU to 64.2
Update the version of the bundled ICU (deps/icu-small) to ICU version
64.2 (Unicode 12, CLDR 35)

Fixes: #26388

PR-URL: #27361
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request May 16, 2019

tools: update LICENSE and tools/icu/current_ver.dep
Update the LICENSE file and tools/icu/current_ver.dep file in order to
finalize the upgrade to ICU 64.2

PR-URL: #27361
Fixes: #26388
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.