Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test:add common.mustCall in test-http-abort-client.js #27449

Closed

Conversation

@OneNailWang
Copy link
Contributor

commented Apr 28, 2019

refactor test-http-abort-client to use common.mustCall (from: code-and-learn)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@yorkie
yorkie approved these changes Apr 28, 2019
@ZYSzys
ZYSzys approved these changes Apr 28, 2019

@ZYSzys ZYSzys added the author ready label Apr 28, 2019

@nodejs-github-bot

This comment has been minimized.

@oyyd

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

Hi, @OneNail . Can you add a space after "test:" like test: add common.mustCall in test-http-abort and make sure the commit message is less than 75 chars per line ?

@OneNailWang OneNailWang force-pushed the OneNailWang:refactorTestHttpAbortClient branch from b67bf3a to 7e2460e Apr 28, 2019

@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Apr 29, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@oyyd

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Landed in 578b31e, thanks!

You can visit https://www.nodetodo.org/next-steps/ for more ideas to contribute.

@oyyd oyyd closed this Apr 30, 2019

oyyd added a commit that referenced this pull request Apr 30, 2019
test: add common.mustCall in test-http-abort-client.js
PR-URL: #27449
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Apr 30, 2019
test: add common.mustCall in test-http-abort-client.js
PR-URL: #27449
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos referenced this pull request May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.