Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: inspect constructor closer #27522

Closed

Conversation

Projects
None yet
6 participants
@BridgeAR
Copy link
Member

commented May 1, 2019

This adds an extra check to util.inspect to closer inspect object
constructors in case there's not much other information about the
constructor.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment was marked as outdated.

Show resolved Hide resolved src/node_util.cc Outdated

@BridgeAR BridgeAR force-pushed the BridgeAR:inspect-constructor-name-closer branch from 8a49467 to 3b22ce9 May 1, 2019

@nodejs-github-bot

This comment was marked as outdated.

@targos

targos approved these changes May 2, 2019

@Trott

Trott approved these changes May 2, 2019

@nodejs-github-bot

This comment was marked as outdated.

util: inspect constructor closer
This adds an extra check to `util.inspect` to closer inspect object
constructors in case there's not much other information about the
constructor.

@BridgeAR BridgeAR force-pushed the BridgeAR:inspect-constructor-name-closer branch from 3b22ce9 to d047763 May 2, 2019

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment has been minimized.

@ZYSzys

ZYSzys approved these changes May 4, 2019

@ZYSzys

This comment has been minimized.

Copy link
Member

commented May 4, 2019

Landed in 7910b02 🎉.

@ZYSzys ZYSzys closed this May 4, 2019

ZYSzys added a commit that referenced this pull request May 4, 2019

util: inspect constructor closer
This adds an extra check to `util.inspect` to closer inspect object
constructors in case there's not much other information about the
constructor.

PR-URL: #27522
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

@targos targos referenced this pull request May 5, 2019

Closed

util: add prototype support for function inspection #27227

4 of 4 tasks complete
@targos

This comment has been minimized.

Copy link
Member

commented May 5, 2019

Backport to v12.x is blocked on #27227.

@BridgeAR BridgeAR referenced this pull request May 5, 2019

Closed

[v12.x] backport 27227 #27570

4 of 4 tasks complete

BridgeAR added a commit to BridgeAR/node that referenced this pull request May 5, 2019

util: inspect constructor closer
This adds an extra check to `util.inspect` to closer inspect object
constructors in case there's not much other information about the
constructor.

PR-URL: nodejs#27522
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

targos added a commit that referenced this pull request May 6, 2019

util: inspect constructor closer
This adds an extra check to `util.inspect` to closer inspect object
constructors in case there's not much other information about the
constructor.

PR-URL: #27522
Backport-PR-URL: #27570
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

@targos targos referenced this pull request May 6, 2019

Merged

v12.2.0 proposal #27578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.